Misc translation 'ts' fixes #14467
Merged
Misc translation 'ts' fixes #14467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
reviewed
Jun 6, 2019
| @@ -133,7 +133,7 @@ public function buildQuickForm() { | |||
| $this->addButtons([ | |||
| [ | |||
| 'type' => 'submit', | |||
| 'name' => ts('Update ' . ucfirst($this::$entityShortname) . 's)'), | |||
| 'name' => ts('Update'), | |||
There was a problem hiding this comment.
So this changes it from eg. "Update Membership" to "Update" - I think that's ok
There was a problem hiding this comment.
yep, fixing this was too complicated, and it seemed like the context was sufficient to understand what is being updated.
mattwire
reviewed
Jun 6, 2019
CRM/Core/Payment/Form.php
Outdated
| @@ -319,7 +319,7 @@ public static function validateCreditCard($values, &$errors, $processorID = NULL | |||
| if (!empty($values['credit_card_type'])) { | |||
| $processorCards = CRM_Financial_BAO_PaymentProcessor::getCreditCards($processorID); | |||
| if (!empty($processorCards) && !in_array($values['credit_card_type'], $processorCards)) { | |||
| $errors['credit_card_type'] = ts('This procesor does not support credit card type ' . $values['credit_card_type']); | |||
| $errors['credit_card_type'] = ts('This procesor does not support credit card type %1', [1 => $values['credit_card_type']]); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mostly NFC, this PR fixes a few places where the
tswas incorrectly used. When incorrectly used, the strings are not extracted, not sent to Transifex, and probably not translated in the UI (in most cases).The main exception might be the
tsremoval inCRM/Contact/Form/Search/Criteria.phpor inCRM/Contact/Form/Task/AddToParentClass.php, but it's a hack, a bad example, and if they cause problems, they should be addressed correctly.