Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create payment activity when creating a payment via the api, test #14452

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Makes api behaviour match the form layer - ie. creating an activity when a payment is made should be path-independent

Before

No activity created when paying via api

After

Activity created & it's tested

Technical Details

This is a pre-requisite for switching AdditionalPayment form to the api

https://github.com/civicrm/civicrm-core/pull/14408/files

Comments

@civibot
Copy link

civibot bot commented Jun 6, 2019

(Standard links)

@civibot civibot bot added the master label Jun 6, 2019
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

@monishdeb this just takes payment activity creation a little further - with test cover

@eileenmcnaughton
Copy link
Contributor Author

@monishdeb wanna merge this - I think it's kinda straight forward & we are super close to switching over on the AdditionalPayment form now!

@mattwire mattwire merged commit fbc5b5b into civicrm:master Jun 12, 2019
@eileenmcnaughton eileenmcnaughton deleted the payment_activity branch June 12, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants