Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caches - Normalize dependency on php-cache integration-tests #14423

Merged
merged 2 commits into from
Jun 4, 2019

Conversation

totten
Copy link
Member

@totten totten commented Jun 4, 2019

Overview

CiviCRM includes cache drivers that comply with PSR-16. The php-cache integration-tests provide a base-class for testing these drivers to ensure compliance with PSR-16.

The base-class was originally loaded as an impromptu fork which provided support for PHPUnit 4. However, since Civi's test suite no longer supports PHPUnit 4 (and does support PHPUnit 6), we can switch to the normal/non-forked version of the base-class.

Before

  • civicrm-packages provides a patched/forked copy of SimpleCacheTest named LegacySimpleCacheTest.
  • The Civi tests extend a variant that worked in PHPUnit 4+5 (class E2E_Cache_CacheTestCase extends ... LegacySimpleCacheTest ... extends \PHPUnit_Framework_TestCase).

After

  • composer.json provides the canonical SimpleCacheTest.
  • The Civi tests extend a variant that works in PHPUnit 5+6 (class E2E_Cache_CacheTestCase extends ... SimpleCacheTest ... extends \PHPUnit\Framework\TestCase).
  • The folder civicrm-packages.git/Cache can be deleted.

@civibot civibot bot added the master label Jun 4, 2019
@civibot
Copy link

civibot bot commented Jun 4, 2019

(Standard links)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants