Caches - Normalize dependency on php-cache integration-tests #14423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CiviCRM includes cache drivers that comply with PSR-16. The php-cache integration-tests provide a base-class for testing these drivers to ensure compliance with PSR-16.
The base-class was originally loaded as an impromptu fork which provided support for PHPUnit 4. However, since Civi's test suite no longer supports PHPUnit 4 (and does support PHPUnit 6), we can switch to the normal/non-forked version of the base-class.
Before
civicrm-packages
provides a patched/forked copy ofSimpleCacheTest
namedLegacySimpleCacheTest
.class E2E_Cache_CacheTestCase extends ... LegacySimpleCacheTest ... extends \PHPUnit_Framework_TestCase
).After
composer.json
provides the canonicalSimpleCacheTest
.class E2E_Cache_CacheTestCase extends ... SimpleCacheTest ... extends \PHPUnit\Framework\TestCase
).civicrm-packages.git/Cache
can be deleted.