phpunit6 - Implement TAP printer #14421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
The `--tap` option was removed in PHPUnit 6.x. For backwared compatibility, the preceding commit adds a printer with same/similar output format. This continues adding the backward comapt by respecting `--tap` as an alias for `--printer Civi/Test/TAP`.
|
Per civicrm/civicrm-buildkit#458 discussion, I've pushed up a revision so that |
totten
changed the title
|
(Note: filled in a better description) |
totten
changed the title
totten
added
the
merge ready
|
Jenkins re test this please |
1 similar comment
|
Jenkins re test this please |
|
Test failures appear unrelated. (And the PR tests wouldn't really hit the new code path anyway.) The console output doesn't show anything weird. On my local system, after checking both PHP 5.x and 7.x, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This bridges a compatibility gap between PHPUnit5 and PHPUnit 6+ -- in that in the latter versions removed support for the
--tapoutput format.Before
tools/scripts/phpunit --tapworks on PHP 5.x / PHPUnit 5tools/scripts/phpunit --tapdoes not work on PHP 7.x / PHPUnit 6+After
tools/scripts/phpunit --tapworks on PHP 5.x / PHPUnit 5tools/scripts/phpunit --tapworks on PHP 7.x / PHPUnit 6+Comments
This is a seamless update on any callers who use the
tools/scripts/phpunitwrapper. However, if you call PHPUnit by other means, then you'll need to change--tapto--printer '\Civi\Test\TAP'.ping @eileenmcnaughton