Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try running unit tests on phpunit6 #14404

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

seamuslee001
Copy link
Contributor

@civibot
Copy link

civibot bot commented Jun 2, 2019

(Standard links)

@civibot civibot bot added the master label Jun 2, 2019
@eileenmcnaughton
Copy link
Contributor

Nice - what about running phpunit 7 for 7.1 + (& maybe 8 for php 7.2+) - we need min phpunit 7 for 7.3 & ideally we would run the most recent version of phpunit that we can to keep our ability to support the latest from regressing

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton this needs @totten to deploy latest buildkit on test-2 first but yeh but PHPUnit7 is throwing more errors (plus more code changes). I need to review in depth first

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 so do you have any reservations about me merging this?

@eileenmcnaughton
Copy link
Contributor

I guess it will require some people to update their buildkit?

@seamuslee001
Copy link
Contributor Author

Yeh pretty much that but i don't have a reservation as such just that we may see failures if something runs on max on test-2 without Tim deploying latest buildkit

@eileenmcnaughton
Copy link
Contributor

let's see how it goes

@eileenmcnaughton eileenmcnaughton merged commit fe0c69b into civicrm:master Jun 3, 2019
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 I wonder if any docs need updating now?

@eileenmcnaughton eileenmcnaughton deleted the test_run_phpunit6 branch June 3, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants