dev/core#1008 add ended status to new contribution recur status group #14403
Conversation
|
(Standard links)
|
| `option_group_id`, {localize field='label'}`label`{/localize}, `value`, `name`, `weight`, `is_reserved`, `is_active`, `is_default` | ||
| ) | ||
| VALUES( | ||
| @option_group_id_ps, 'Ended', @maxValue + 3, 'Processing', @maxWeight + 3, 1 , 1 , 0 |
There was a problem hiding this comment.
same as #14395 (comment)
| @@ -9,3 +9,33 @@ SELECT @option_group_id_ps as option_group_id, {localize field='label'}`label`{/ | |||
| FROM civicrm_option_value ov | |||
| INNER JOIN civicrm_option_group og | |||
| ON og.id = ov.option_group_id AND og.name = 'contribution_status'; | |||
|
|
|||
| SELECT @maxValue := MAX(value) FROM `civicrm_option_value` where option_group_id = @option_group_id_ps; | |||
There was a problem hiding this comment.
value is of type VARCHAR so MAX won't be accurate unless we convert it.
SELECT @maxValue := MAX(CAST( valueAS UNSIGNED )) FROMcivicrm_option_value where option_group_id = @ option_group_id_ps;
eileenmcnaughton
force-pushed
the
recur_status2
branch
from
ddd24f0
to
934848f
Compare
Per https://lab.civicrm.org/dev/core/issues/1008 I think there is a case for another using facing status for the nunaces on ways that recurrings end - somewhere between 'they actively cancelled it' and 'they completed it' lies - it ended & neither of the others are quite the right fit
eileenmcnaughton
force-pushed
the
recur_status2
branch
from
934848f
to
4e435b3
Compare
|
@pradpnayak this is now ready to merge right? |
|
I guess I disagree with the premise of this--it sounds like a wording change or a site-specific nuance. I'll go into more depth on dev/core#1008. In one sense it's harmless, but in another, we're cluttering up the interface with extra options that may confuse the user. |
|
I wrote a bit at https://lab.civicrm.org/dev/core/issues/1008#note_18551. Basically, unlike the new statuses in #14395, this doesn't come with a natural programmatic distinction. In fact, "Ended" isn't added to the hard-coded list of inactive statuses: civicrm-core/CRM/Contribute/BAO/ContributionRecur.php Lines 932 to 934 in a988223 However, instead of just adding a new thing to that list, I just thing there's a case for keeping the reserved statuses that need to be there but then letting site owners add statuses if they feel the current ones are insufficient. |
|
@agh1 perhaps we could co-opt the 'grouping' field or the 'filter' field - if the latter it would mean 'filter' =>1 would be 'active' |
| @@ -1056,6 +1056,7 @@ VALUES | |||
| (@option_group_id_crs, '{ts escape="sql"}Overdue{/ts}' , 6, 'Overdue' , NULL, 0, NULL, 6, NULL, 0, 1, 1, NULL, NULL, NULL), | |||
| (@option_group_id_crs, '{ts escape="sql"}Processing{/ts}' , 7, 'Processing' , NULL, 0, NULL, 7, NULL, 0, 1, 1, NULL, NULL, NULL), | |||
| (@option_group_id_crs, '{ts escape="sql"}Failing{/ts}' , 8, 'Failing' , NULL, 0, NULL, 8, NULL, 0, 1, 1, NULL, NULL, NULL), | |||
| (@option_group_id_crs, '{ts escape="sql"}Ended{/ts}' , 9, 'Ended' , NULL, 0, NULL, 8, NULL, 0, 1, 1, NULL, NULL, NULL), | |||
There was a problem hiding this comment.
7th column should 9 instead 8?
|
thanks @yashodha @pradpnayak I think we need to slow this down on concept approval though |
|
I'm closing this for now - It is targetting 5.15 & is not going to be merged for that release so needs re-work. In addition the concept is not agreed so github isn't the place to track it |
Overview
Per https://lab.civicrm.org/dev/core/issues/1008 I think there is a case for another using facing status for the
nunaces on ways that recurrings end - somewhere between 'they actively cancelled it' and 'they completed it'
lies - it ended & neither of the others are quite the right fit
Before
Ended status does not exist
After
Ended status exists
Technical Details
Builds on the work in #14395 & the earlier PR that separated out recurring contribution statuses from contribution statuses
Comments