Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wysiwyg support for i18n event fields #14384

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

samuelsov
Copy link
Contributor

Overview

Following #5734, adds support for wysiwyg editor in i18n popup for event fields

Before

Screenshot_2019-05-30 Configure Event

After

Screenshot_2019-05-30 Configure Event - with WYSIWYG

Technical Details

The xml will be used to generate CRM_Core_I18n_SchemaStructure::widgets that is used by the i18n popup.

Comments

See also #5734

@civibot
Copy link

civibot bot commented May 30, 2019

(Standard links)

@civibot civibot bot added the master label May 30, 2019
@colemanw
Copy link
Member

Test this please

@colemanw
Copy link
Member

@samuelsov I agree with this in principle, but when I went to test it on the PR demo sandbox site it was all messed up with errors about missing language files. That seems unlikely to have been caused by this PR itself, but maybe it's due to some testing you were doing on that site? Anyway I've triggered a rebuild and will test again once that's done.

@mattwire
Copy link
Contributor

@colemanw That was because of #14385

@colemanw
Copy link
Member

colemanw commented Jun 1, 2019

I've tested this and it works well, but I did notice a bug where saving the popup doesn't correctly copy the updated info back to the form underneath. This works with non-wysiwyg forms tho.

@colemanw colemanw merged commit b6dd10c into civicrm:master Jun 1, 2019
@eileenmcnaughton
Copy link
Contributor

@colemanw @samuelsov was this data already stored in the DB in html? It will be stored in html after this change and we've had problems with a seeming 'just a ui tweak' actually changing how data is stored / appears before - although I can't remember all the details

@eileenmcnaughton
Copy link
Contributor

(also DAO need to be regenerated & submitted)

@colemanw
Copy link
Member

colemanw commented Jun 1, 2019

@eileenmcnaughton if you look at the patch, this doesn't change the <type> tag being nested within the <html> tag, if that's what you mean.

@colemanw
Copy link
Member

colemanw commented Jun 1, 2019

See #14396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants