-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wysiwyg support for i18n event fields #14384
Conversation
(Standard links)
|
Test this please |
@samuelsov I agree with this in principle, but when I went to test it on the PR demo sandbox site it was all messed up with errors about missing language files. That seems unlikely to have been caused by this PR itself, but maybe it's due to some testing you were doing on that site? Anyway I've triggered a rebuild and will test again once that's done. |
I've tested this and it works well, but I did notice a bug where saving the popup doesn't correctly copy the updated info back to the form underneath. This works with non-wysiwyg forms tho. |
@colemanw @samuelsov was this data already stored in the DB in html? It will be stored in html after this change and we've had problems with a seeming 'just a ui tweak' actually changing how data is stored / appears before - although I can't remember all the details |
(also DAO need to be regenerated & submitted) |
@eileenmcnaughton if you look at the patch, this doesn't change the |
See #14396 |
Overview
Following #5734, adds support for wysiwyg editor in i18n popup for event fields
Before
After
Technical Details
The xml will be used to generate CRM_Core_I18n_SchemaStructure::widgets that is used by the i18n popup.
Comments
See also #5734