Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#994 remove Thousands Separator can not have more than 1 character rule #14376

Merged
merged 1 commit into from
May 30, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 29, 2019

Overview

Removes form rule preventing location separators having more than one character.

Before

Can't save a non-breaking space as a thousand separator

After

Can save a non-breaking space (or other string longer than one char)

Technical Details

Per issue it seems unnecessarily opinionated to block longer strings & we not know of at least one case where it is inappropriate

Comments

…acter rule

Per issue it seems unnecessarily opinionated to block longer strings & we not know of at least one case where it is inappropriate
@civibot
Copy link

civibot bot commented May 29, 2019

(Standard links)

@civibot civibot bot added the master label May 29, 2019
@eileenmcnaughton
Copy link
Contributor Author

@mlutfy ^^

@mlutfy
Copy link
Member

mlutfy commented May 30, 2019

I did a bit of testing on the demo site: changed the separator to two spaces, added a new contribution, edited the contribution with changes, edited without changes.

@mlutfy mlutfy merged commit 2d08f8d into civicrm:master May 30, 2019
@eileenmcnaughton eileenmcnaughton deleted the location_form branch May 30, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants