Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove confusing pass params by ref #14360

Merged
merged 1 commit into from
May 28, 2019
Merged

Remove confusing pass params by ref #14360

merged 1 commit into from
May 28, 2019

Conversation

colemanw
Copy link
Member

Overview

Remove a confusing & that is not needed.

Before

Variable passed by ref but not modified.

After

Variable passed normally.

@civibot
Copy link

civibot bot commented May 27, 2019

(Standard links)

@civibot civibot bot added the master label May 27, 2019
@eileenmcnaughton
Copy link
Contributor

I agree this is not required. Test fail does not relate

@eileenmcnaughton eileenmcnaughton merged commit ffe9ab5 into civicrm:master May 28, 2019
@eileenmcnaughton eileenmcnaughton deleted the byRef branch May 28, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @eileenmcnaughton