Fix name of cache key column to be all lower case rather than camel c… #14359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
fix_cache_key_column
branch
from
820fa2e
to
bad52d5
Compare
|
Looks good - I'll let jenkins weigh in before I dig deeply |
|
Test failures appear to relate will investigate shortly |
…ase in civicrm_prevnext_cache Fix test failures
seamuslee001
force-pushed
the
fix_cache_key_column
branch
from
bad52d5
to
783b4b2
Compare
|
@eileenmcnaughton i think i have fixed the Jenkins failures now |
|
@seamuslee001 this looks good to me - let's merge if tests pass & then I'll do some more work on dedupe cleanup after which should put it through it's paces even more |
|
Yay @seamuslee001 that will save future pain! |
|
@totten - FYI I know you've done a lot of work in the cache system, so if you or @eileenmcnaughton have any extensions e.g. for the WMF caching project that query this table, they will need to be updated. |
|
@colemanw thanks for thinking of that but no that should not apply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ase in civicrm_prevnext_cache
Overview
This renames the cacheKey column to be cachekey to be more standard with other column names
Before
camelCase column name used
After
lower case used
ping @eileenmcnaughton @colemanw