Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation in billingblock.tpl - dropping 'Information' #14358

Merged
merged 1 commit into from
May 27, 2019

Conversation

samuelsov
Copy link
Contributor

@samuelsov samuelsov commented May 27, 2019

Overview

Problem with the translation of the fieldset legend for payment block.

This PR is a replacement for #14253

It's quite difficult to translate properly because the payment processor type is dynamic and could be overridden by extensions. Removing the 'Information' part and let the payment processor be responsible for giving the (translated) label.

Before

In contribution or event payment forms, when an amount and a payment processor is selected, displays the untranslated title : "Credit Card Information" or "Debit Card Information" or "Unicorn Information"

After

Displays translated : "Credit Card" or "Debit Card" or "Unicorn"

Comments

This PR is a replacement for #14253

@civibot
Copy link

civibot bot commented May 27, 2019

(Standard links)

@civibot civibot bot added the master label May 27, 2019
@eileenmcnaughton eileenmcnaughton merged commit e713601 into civicrm:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants