Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for FGB error in #14331 #14340

Merged
merged 1 commit into from
May 26, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 26, 2019

Overview

Adds unit test to demonstrate that without #14331 we get an error

Before

No test cover

After

Test cover

Technical Details

@seamuslee001 despite the temptation I couldn't justify fixing #14331 without a test as I wouldn't have accepted a FGB fix from someone else without one & really if it was just a case of fixing without a test I would have done it 2 months ago https://lab.civicrm.org/dev/core/issues/754 since it would have been a 5 minute job

Comments

@civibot
Copy link

civibot bot commented May 26, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

Merging as it affects tests and is a test for another PR

@seamuslee001 seamuslee001 merged commit c7d9deb into civicrm:master May 26, 2019
@seamuslee001 seamuslee001 deleted the select2 branch May 26, 2019 03:14
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 hmm - that should have failed - it failed locally without the other patch

@seamuslee001
Copy link
Contributor

@eileenmcnaughton it did i have merged and kicked off tests on the one

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 ah right - I thought you'd merge in the reverse order - but no - you are on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants