[REF] Stop passing cacheKey to refillCache #14337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
dedupe_cleanup
branch
from
79134ec
to
1a9409d
Compare
|
@colemanw minor related cleanup - I'm going to start on next round soon |
|
@eileenmcnaughton Needs rebase |
|
Agree it needs a rebase. Otherwise, merge on pass. |
The function is only called from one place & there is no need to pass it in
eileenmcnaughton
force-pushed
the
dedupe_cleanup
branch
from
1a9409d
to
e1e24a5
Compare
|
rebased |
|
Merging as per @totten 's comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor function cleanup
Before
Unnecessary param passed in
After
Unnecessary param removed.
Technical Details
The function is only called from one place & there is no need to pass it in
Comments