dev/core#879 SMTP help text is misleading - references the wrong admin screen #14329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton the style checker has logged on https://test.civicrm.org/job/CiviCRM-Core-PR/26417/checkstyleResult/new/ |
magnolia61
pushed a commit
to magnolia61/civicrm-core
that referenced
this pull request
Oct 13, 2019
…tact Info instead of leading to From Email Addresses; see also civicrm#14055 and civicrm#14329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fairly simple - the help text was wrong and did not match the URL, which is correct. See https://civicrm.stackexchange.com/questions/29261/how-to-setup-civicrm-to-proper-send-authenticated-dkim-emails/29264#29264 and https://lab.civicrm.org/dev/core/issues/879
Before
Text points to Communications -> FROM Email Addresses
After
Text points to Communications -> Organization Address and Contact Info
Technical Details
Reviewer's commit of #14055 (squashed commits, incorporated @mattwire suggestion to switch to statusBounce, hence adding merge-on-pass
Comments
Also minor comments cleanup, remove unused var