Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix comment block for variable declarations #14314

Merged
merged 1 commit into from
May 24, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Update variable declaration blocks to match correct format

Before

'Integer' etc

After

int, string

Technical Details

Per civicrm/coder#7

Comments

@civibot
Copy link

civibot bot commented May 23, 2019

(Standard links)

@civibot civibot bot added the master label May 23, 2019
@colemanw
Copy link
Member

@eileenmcnaughton

Parser.php:1359, CommaLastItem, Priority: Normal
--
A comma should follow the last multiline array item. Found: 1

@eileenmcnaughton
Copy link
Contributor Author

@colemanw yeah - that was already there but I fixed - I think we should merge civicrm/coder#7 - I'm not finding more of the newly enabled check now than others - feels not too onerous to me

@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

This is just changing doc block comments, Jenkins is the only checker here and its passed the style merging

@seamuslee001 seamuslee001 merged commit dfe6405 into civicrm:master May 24, 2019
@seamuslee001 seamuslee001 deleted the coder branch May 24, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants