Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/joomla#11 Fix php warning when viewing profiles #14312

Merged
merged 1 commit into from
May 23, 2019

Conversation

spalmstr
Copy link
Contributor

@spalmstr spalmstr commented May 23, 2019

Overview

Fixes php warning message

Before

_The current status.
When viewing a contact at the Joomla front end you can get this warning:
Warning: hash_equals(): Expected user_string to be a string, null given in .../administrator/components/com_civicrm/civicrm/CRM/Contact/BAO/Contact/Utils.php on line 232

After

_What has been changed.

Casting the user_string explicitly to a string variable removes the error.

Technical Details

Change line 232 as follows:
if (!hash_equals($check, (string) $inputCheck)) {

Comments

https://lab.civicrm.org/dev/joomla/issues/11

@civibot
Copy link

civibot bot commented May 23, 2019

(Standard links)

@civibot civibot bot added the master label May 23, 2019
@mattwire
Copy link
Contributor

test this please

@eileenmcnaughton eileenmcnaughton changed the title Joomla_11 Patch CRM/Contact/BAO/Contact/Utils.php dev/joomla#11 Fix php warning when viewing profiles May 23, 2019
@eileenmcnaughton eileenmcnaughton merged commit a8bd88a into civicrm:master May 23, 2019
@eileenmcnaughton
Copy link
Contributor

I fixed up the pr message a little -note that the way to grab the reference from gitlab is

Screen Shot 2019-05-24 at 10 58 01 AM

I also tend to add links back to gitlab as the bot doesn't do that :-(

@spalmstr spalmstr deleted the Joomla_11 branch March 9, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants