[NFC] Fix variable types in DAO doc blocks #14294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phpcs (stricter) reports 79 | ERROR | [x] Expected "intunsigned" but found "int unsigned" for @var tag in member variable comment 156 | ERROR | [x] Expected "bool" but found "boolean" for @var tag in member variable comment We are declaring int unsigned instead of int & boolean instead of bool Note this commit only contains sample of resulting change - will add more complete set after
|
(Standard links)
|
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Standards cleanup on docblock comments - no functional change
Before
type declared as int unsigned & boolean
After
type declared as int & bool
Technical Details
Phpcs (stricter) reports
79 | ERROR | [x] Expected "intunsigned" but found "int unsigned" for @var tag in member variable comment
156 | ERROR | [x] Expected "bool" but found "boolean" for @var tag in member variable comment
We are declaring int unsigned instead of int & boolean instead of bool
Note this commit only contains sample of resulting change - will add more complete set after
Comments
See civicrm/coder#7