Reduce cache bypasses - do not bypass custom metadata cache in setGroupTree #14292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
cachedtree
branch
from
18c251e
to
42313b9
Compare
eileenmcnaughton
force-pushed
the
cachedtree
branch
from
42313b9
to
17571eb
Compare
We have been running this patch in production for some months. When you load up a contribution edit page (for example) the custom data metadata is loaded without hitting the cache. This means that unnecessary queries are done. The only reason to bypass the cache would be that it is stale or parameter dependent. However, the staleness is/ should be dealt with when editing custom fields & if it is not then there will be other impacts. The entity id is NOT passed into the part of the code that goes into the cached value
eileenmcnaughton
force-pushed
the
cachedtree
branch
from
17571eb
to
1203c8d
Compare
|
I've added 'ok without test' as I could see lots of tests error when I had an enotice in this! - also, it's just caching |
|
test this please |
2 similar comments
|
test this please |
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When editing a form with custom data on it the cached metadata is ignored &I rebuilt. This changes it to use it
Before
More DB queries
After
Less DB queries
Technical Details
We have been running this patch in production for some months. When you load up a contribution edit page
(for example) the custom data metadata is loaded without hitting the cache. This means that
unnecessary queries are done. The only reason to bypass the cache would be that it is stale
or parameter dependent. However, the staleness is/ should be dealt with when editing custom
fields & if it is not then there will be other impacts. The entity id is NOT passed into the part of
the code that goes into the cached value
In order to demonstrate the params that go into the cache are in the cachekey I also did an extraction
Comments