[REF] Simplify ACL page template #14288
Conversation
|
(Standard links)
|
|
Oh - I tested on D7, D8, Backdrop, and WP, not Joomla though. |
|
@mlutfy this looks good to me - no translation concerns? |
| {elseif $config->userFramework EQ 'WordPress'} | ||
| <p>{ts 1=$ufAccessURL}Use <a href='%1'>WordPress Access Control</a> to manage basic access to CiviCRM components and menu items. Use CiviCRM ACLs to control access to specific CiviCRM contact groups. You can also configure ACLs to grant or deny access to specific Events, Profiles, and/or Custom Data Fields.{/ts}</p> | ||
| {/if} | ||
| <p>{ts 1=$ufAccessURL 2=$jAccessParams 3=$config->userFramework}Use <a href='%1' %2>%3 Access Control</a> to manage basic access to CiviCRM components and menu items. Use CiviCRM ACLs to control access to specific CiviCRM contact groups. You can also configure ACLs to grant or deny access to specific Events, Profiles, and/or Custom Data Fields.{/ts}</p> |
There was a problem hiding this comment.
I have mixed feelings about this, because it is exposing a machine-name that happens to be convenient in English, but given that it's the ACL admin form, I'm not opposed to the cleanup.
Also, the expression %1 Access Control is already present in that page, so this is not introducing a regression from the point of view of i18n.
You can ignore this:
-
It's a form of concatenation which may not fit in all languages, although it should be OK in the languages I know, so maybe not a big deal.
-
In non-latin languages, people may or may not translate the CMS name. For example, Друпал in Russian (although the current Russian translation of CiviCRM uses 'Drupal' and not 'Друпал', which may sound obvious, but McDonalds in Russia is Макдоналдс, for example).
-
Does "Use Drupal8 Access Control" sound OK? (given that this is a geeky admin form, I don't really mind, but it is a bit inconsistent)
-
I would have recommended to use "Content Management System Access Control", but I have to admit that it's both annoyingly long and vague.
Overview
I noticed that the ACL page template says "Drupal Access Control" on Backdrop. When I went to look at it, I realized that there was no need for the complex conditionals at all.
Before
ACL page works except with a bad label on Backdrop.
After
ACL page still works, Backdrop label is accurate, file has 25% fewer lines and no conditionals.