Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#980 [test-dbunit] Cleanup profile test to not use discontinuted dbunit #14279

Merged
merged 1 commit into from
May 23, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 21, 2019

Overview

Removes reliance from ProfileTest class on discontinued dbunit package

Before

dbunit used to set up data

After

Api functions used

Technical Details

per #14321 dbunit is no longer supported. It also adds complexity managing phpunit version migration

Comments

https://lab.civicrm.org/dev/core/issues/980

@civibot
Copy link

civibot bot commented May 21, 2019

(Standard links)

@civibot civibot bot added the master label May 21, 2019
@eileenmcnaughton eileenmcnaughton changed the title [test-dbunit] Cleanup profile test to not use discontinuted dbunit dev/core#980 [test-dbunit] Cleanup profile test to not use discontinuted dbunit May 21, 2019
@eileenmcnaughton eileenmcnaughton force-pushed the db_test2 branch 2 times, most recently from 88313fb to d5f00ca Compare May 23, 2019 01:48
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 can you merge this?

@seamuslee001
Copy link
Contributor

Confirmed the changes match the dataset merging as test pass

@seamuslee001 seamuslee001 merged commit c55429d into civicrm:master May 23, 2019
@eileenmcnaughton eileenmcnaughton deleted the db_test2 branch May 23, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants