Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#980 [test-dbunit] Test cleanup to remove references to discontinued package dbunit #14276

Merged
merged 3 commits into from
May 21, 2019
Merged

dev/core#980 [test-dbunit] Test cleanup to remove references to discontinued package dbunit #14276

merged 3 commits into from
May 21, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 20, 2019 •
edited
Loading

Overview

Per #14268 dbunit is discontinued. This helps remove a dependency on it

Before

Tests use dbunit functions for data set up

After

Tests use civi functions

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 20, 2019

(Standard links)

@civibot civibot bot added the master label May 20, 2019
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 I got a pass on this

@seamuslee001
Copy link
Contributor

Merging this as only affects tests and Jenkins has said its ok

@seamuslee001 seamuslee001 merged commit 31e0024 into civicrm:master May 21, 2019
@seamuslee001 seamuslee001 deleted the dbunit_2 branch May 21, 2019 05:44
@eileenmcnaughton eileenmcnaughton changed the title Test cleanup to remove references to discontinued package dbunit [test-dbunit] Test cleanup to remove references to discontinued package dbunit May 21, 2019
@eileenmcnaughton eileenmcnaughton changed the title [test-dbunit] Test cleanup to remove references to discontinued package dbunit dev/core#980 [test-dbunit] Test cleanup to remove references to discontinued package dbunit May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001