dev/core#980 [test-dbunit] Remove some use of dbunit from tests #14271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
db_test_towards
branch
2 times, most recently
from
28c50a8
to
eb47bfb
Compare
eileenmcnaughton
force-pushed
the
db_test_towards
branch
from
eb47bfb
to
cfebd64
Compare
eileenmcnaughton
force-pushed
the
db_test_towards
branch
from
cfebd64
to
1955a28
Compare
eileenmcnaughton
force-pushed
the
db_test_towards
branch
from
1955a28
to
f9a5aad
Compare
|
test this please |
|
@colemanw @seamuslee001 can one of you merge? |
|
Only affects tests and Jenkins has passed it merging |
eileenmcnaughton
changed the title
eileenmcnaughton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per #14268 this removes some places where tests use discontinued dbunit classes & in these cases they seem to add little to no value
Before
DB unit class used
After
Not used
Technical Details
There are a handful of places where the function to use an xml dataset are used. Working through them...
Comments