Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken delete from customGroupCreate #14239

Merged
merged 1 commit into from
May 13, 2019

Conversation

colemanw
Copy link
Member

Overview

Removes a broken api call from unit tests. This only affects tests.

Before

Have a crack at using the api with the wrong syntax.

After

Don't bother.

Technical Details

If you look closely at the api call, it was broken. Probably a copy-paste error, as other places in the test suite the params consist only of array('api.foo.bar' => 1) but here they accidentally wrapped that array in another array, which would cause it to be ignored.
Rather than fix it, I concluded that it isn't needed because tests pass without it.

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented May 13, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

Merging this as only affects tests and Jenkins has oked it

@seamuslee001 seamuslee001 merged commit f3171f1 into civicrm:master May 13, 2019
@colemanw colemanw deleted the haveACrack branch May 13, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants