Remove broken delete from customGroupCreate #14239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes a broken api call from unit tests. This only affects tests.
Before
Have a crack at using the api with the wrong syntax.
After
Don't bother.
Technical Details
If you look closely at the api call, it was broken. Probably a copy-paste error, as other places in the test suite the params consist only of
array('api.foo.bar' => 1)
but here they accidentally wrapped that array in another array, which would cause it to be ignored.Rather than fix it, I concluded that it isn't needed because tests pass without it.
Comments
Anything else you would like the reviewer to note