dev/core#953 Add test for updating email via import & ensuring it is primary #14225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_test
branch
2 times, most recently
from
5c2cfb7
to
373c66c
Compare
…rimary on import Add test for updating email via import & ensuring it is primary
eileenmcnaughton
force-pushed
the
import_test
branch
from
373c66c
to
12e2ccd
Compare
|
@stesi561 did you get around to testing this? |
|
Sorry - I'll try and get to this tonight. |
|
test this please |
|
I've just tried on 5.13.4 wordpres version - with the patch. And works as expected. I haven't tested any other behaviour. |
|
Merging based on @stesi561 review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add test attempting to replicate dev/core#953
Before
No test
After
test
Technical Details
@stesi561 I didn't manage to replicate the bug in a test.
But if you look at CRM_Contact_Import_Parser_ContactTest::testImportPrimaryAddress it has location type mappings so maybe that needs to be added to the test to get it to replicate the bug - what location type are you mapping to?
Comments