crmRouteBinder - Remove params from url if they equal their defaults #14211
Conversation
|
(Standard links)
|
| @@ -50,18 +50,18 @@ | |||
| registerGlobalListener($injector); | |||
|
|
|||
| options.format = options.format || 'json'; | |||
| var fmt = formats[options.format]; | |||
| var fmt = _.clone(formats[options.format]); | |||
| if (options.deep) { | |||
| fmt.watcher = '$watch'; | |||
There was a problem hiding this comment.
Adding _.clone() on l53 prevents line 55 here from modifying the global defaults.
|
|
||
| var $route = $injector.get('$route'), $timeout = $injector.get('$timeout'); | ||
|
|
||
| var value; |
| if (p[k] === v) { | ||
| delete p[k]; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Just cleanup - expanded the 1-liner on l82 to be more readable.
|
I haven't tested, but want to give a conceptual 👍 -- if the same value would be loaded as a default, then it's preferable to appear shorter and normalized. For someone
|
This works as nicely as before
This works too. I managed to break this if I added multiple parameters with the same key but it's also the case without this commit, I checked.
This is fine. No problem modifying the existing parameters nor adding new one.
It works
It works too I tested all those points against dmaster using firefox nightly (for maximum breakage) and chromium. |
Overview
Reduces url clutter in the Api4 explorer and fixes a bug with
nullbeing cast to0.Before
When removing a param in the api4 explorer, it persists in the url. This is a problem in the case of the
Relationshipapi and the$currentparam. To reproduce:Relationshipget.Currentradio button.xto clear theCurrentradio selection.current=0is still in the url.falseradio will be selected inappropriately.After
Clearing a selection from the api explorer will remove it from the url, which reduces clutter and prevents errors.