Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#932 Fix dedupe contacts flip selection #14195

Merged
merged 1 commit into from
May 12, 2019

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented May 3, 2019

Overview

How to reproduce on dmaster:

Then notice that)

  • when we click on "flip" for a single entry, it seems to flip, but the "merge" link is the same, so doing the actual merge does not flip the direction.
  • if we click the checkbox for the result, then click the "Flip selected duplicates", nothing happens.

civicrm-dedupe-flip

Before

Flipping had no visual effect, and multi-flipping had no effect at all (did not update the dupes in the prevnext cache).

After

Works as expected.

Technical Details

I had to partially revert a change that was done a long time ago regarding $prevNextId = $_REQUEST['pnid'];. Is there a way to use CRM_Utils_Request::retrieveValue on an URL param that can sometimes be an array? (it would be better to have two different AJAX endpoints for this, imho)

https://lab.civicrm.org/dev/core/issues/932

@civibot
Copy link

civibot bot commented May 3, 2019

(Standard links)

@civibot civibot bot added the master label May 3, 2019
@eileenmcnaughton
Copy link
Contributor

I gave this a quick test & agree this fixes the bug & does not introduce a security issue. Mergint

@eileenmcnaughton eileenmcnaughton merged commit 2cfc5ca into civicrm:master May 12, 2019
@eileenmcnaughton eileenmcnaughton deleted the dev932 branch May 12, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants