dev/core#932 Fix dedupe contacts flip selection #14195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
How to reproduce on dmaster:
Then notice that)
Before
Flipping had no visual effect, and multi-flipping had no effect at all (did not update the dupes in the prevnext cache).
After
Works as expected.
Technical Details
I had to partially revert a change that was done a long time ago regarding
$prevNextId = $_REQUEST['pnid'];
. Is there a way to useCRM_Utils_Request::retrieveValue
on an URL param that can sometimes be an array? (it would be better to have two different AJAX endpoints for this, imho)https://lab.civicrm.org/dev/core/issues/932