Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#926 [ref] adds a test & does a preliminary extraction #14181

Merged
merged 2 commits into from
May 12, 2019
Merged

dev/core#926 [ref] adds a test & does a preliminary extraction #14181

merged 2 commits into from
May 12, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 2, 2019 •
edited
Loading

Overview

Code clean up preparatory to fixing a smart group search bug (where removed contacts can't be searched for)

Before

No test, less readable

After

Test, more readable

Technical Details

Function extraction.

Comments

@eileenmcnaughton
Add unit test for group_contact_status in search
8d710ea 
This currently works for non-smart groups so this will pass.
@civibot
Copy link

civibot bot commented May 2, 2019

(Standard links)

@civibot civibot bot added the master label May 2, 2019
@eileenmcnaughton eileenmcnaughton changed the title Group search dev/core#926 [ref] adds a test & does a preliminary extraction May 2, 2019
@eileenmcnaughton eileenmcnaughton mentioned this pull request May 2, 2019
Closed
@colemanw
Copy link
Member

Looks like a useful refactor; +1 for adding a test.

@colemanw colemanw merged commit ca409c4 into civicrm:master May 12, 2019
@colemanw colemanw deleted the group_search branch May 12, 2019 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw