Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#562 [cleanup] remove some more instances of ->free() #14179

Merged
merged 1 commit into from
May 2, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Code cleanup - Removes deprecated pattern that can have implications although none currently n our radar

Before

$dao->free() used more

After

$dao->free() used less

Technical Details

We've been chipping away at this for a while - no issues to date - perhaps we should be more aggressive but this is just another 'monthly bout'

Comments

@civibot
Copy link

civibot bot commented May 2, 2019

(Standard links)

@civibot civibot bot added the master label May 2, 2019
@colemanw
Copy link
Member

colemanw commented May 2, 2019

Eileen frees more frees. Chill!

image

Mr. Freeze approves of freezing the frees.

@eileenmcnaughton eileenmcnaughton merged commit ce73a93 into civicrm:master May 2, 2019
@eileenmcnaughton eileenmcnaughton deleted the free_dao branch May 2, 2019 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants