Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert dedupe select to select 2 and remove not-used var #14161

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Convert dedupe select to select 2 and remove not-used var #14161

merged 1 commit into from
Apr 30, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 30, 2019 •
edited
Loading

Overview

Converts the field to select fields on dedupe rules form to select2

Before

Screenshot 2019-04-30 17 05 17

After

Screenshot 2019-04-30 17 04 25

Technical Details

The $disabled var is empty & stays empty - it looks very very much like a typo

Comments

@civibot civibot bot added the master label Apr 30, 2019
@civibot
Copy link

civibot bot commented Apr 30, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw
Copy link
Member

I agree $disabled looks useless.

@colemanw colemanw merged commit 126d764 into civicrm:master Apr 30, 2019
@colemanw colemanw deleted the really branch April 30, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw