dev/core#913 - update autogenerated .htaccess for apache 2.4

[demeritcowboy]

Overview

See https://lab.civicrm.org/dev/core/issues/913

Before

The current autogenerated .htaccess is for apache 2.2. It happens to work on apache 2.4 because it gives an internal error, but that's obviously not what was intended. It may also happen to work on apache 2.4 if mod_access_compat happens to be installed.

After

Works on apache 2.4 with no log errors. Falls back to current behavior if it can't tell if it's apache 2.4 or higher.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[pfigel]

You can use something like this to have a single .htaccess that is compatible with both versions of apache:

# Apache 2.2
<IfModule !authz_core_module>
  Order Deny,Allow
  Deny from all
</IfModule>

# Apache 2.4+
<IfModule authz_core_module>
  <RequireAll>
    Require all denied
  </RequireAll>
</IfModule>

This has the advantage of continuing to work if installs move back and forth between apache versions (or if version detection fails).

(Based on an example in .htaccess made easy.)

[demeritcowboy]

Thanks! I'll take a look. Makes sense. The Order is backwards but it's because in that example they are doing something slightly different. Similarly the RequireAll isn't needed. Anyway I have a 2.2 and 2.4 so I'll test it out.

[demeritcowboy]

Oops. Somehow that closed the PR.

[pfigel]

Looks great now, thanks @demeritcowboy!

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) PASS
  • (r-user) PASS: Fixes a bug with little user impact.
  • (r-doc) PASS
  • (r-run) PASS: Config blocked access when tested against apache 2.2 and 2.4.
• Developer standards
  • (r-tech) PASS: Fix improves compatibility.
  • (r-code) PASS
  • (r-maint) PASS
  • (r-test) PASS

[demeritcowboy]

Thanks for reviewing @pfigel

[eileenmcnaughton]

reviewing based on @pfigel review

[edvanleeuwen]

Duplicate of https://issues.civicrm.org/jira/browse/CRM-21571

[demeritcowboy]

@edvanleeuwen Ahh I never saw that. I see you had some technical trouble getting a pull request posted back then - it is pretty tricky. You can see farther up here I accidentally closed this one in the middle somehow and I'm still not sure how I did that. I don't know if you asked in chat.civicrm.org back then but in future you can also ask there which is sometimes helpful for those technical hurdles.