dev/core#907 Fix Deprecation notice for PHP7.2 in bin/cli.class.php

[seamuslee001]

Overview

Title says it all

Before

Deprecation notice shows

After

No deprecation notice

ping @eileenmcnaughton

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

jenkins is not happy @kcristiano can you test this - these each ones hurt my brain for some reason so I think I'd rather we do run a proper test

[seamuslee001]

@eileenmcnaughton i created this little snippet of code

<?php
$array = [4,3,2,1];
while (list($k, $arg) = each($array)) {
  print_r("key {$k}, arg {$arg}\n");
}

foreach ($array as $k => $arg) {
  print_r("key {$k}, arg {$arg}\n");
}

which produced the following result

key 0, arg 4
key 1, arg 3
key 2, arg 2
key 3, arg 1
key 0, arg 4
key 1, arg 3
key 2, arg 2
key 3, arg 1

[kcristiano]

@eileenmcnaughton I have tested, and I am not seeing any errors in my logs. But I was unable to reproduce without the patch either.

I've been using cli.php to run cron, is there a specific way to reproduce?

It does seem late to get this in to 5.13, would we be better off waiting to 5.14?

[seamuslee001]

@kcristiano you will need to be using PHP7.2 for your cron job and i think you may need to ensure you are outputting E_WARNING

[kcristiano]

@seamuslee001 Thanks. Turns out my cli was 7.3 with limited reporting (Errors only) I was able to reproduce by explicitly calling 7.2.

The Patch corrects the notice.