dev/core#723 [REF] Declare contactType var rather than using long array syntax. #14146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
Very small tidy up for legibility
eileenmcnaughton
force-pushed
the
dedupe6
branch
from
4a1d291 to
1acd98e
Compare
|
test this please |
|
This looks like a pretty safe extraction and i'm sure Jenkins has enough tests in this area to tell us if something is going wrong merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Very small tidy up for readability
Before
Long string used to refer to contactType
After
Variable used
Technical Details
This one is pretty small but it allows this chunk a7369a0 of code to be extracted without having to pass the unweildly array in
Comments
Anything else you would like the reviewer to note