dev/core#723 [REF] extract chunk of code that definitely does something. #14144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
dedupe4
branch
from
32956c4 to
6ff55f5
Compare
|
@eileenmcnaughton this needs a rebase |
eileenmcnaughton
force-pushed
the
dedupe4
branch
from
6ff55f5 to
d8b23f4
Compare
|
@seamuslee001 done |
eileenmcnaughton
force-pushed
the
dedupe4
branch
from
d8b23f4 to
c062df9
Compare
This is a really blunt extraction of a chunk of code whose Raison D'Etre I don't quite know as yet. I've done the absolute minimum variable cleanup to keep it really clean in the first instance
eileenmcnaughton
force-pushed
the
dedupe4
branch
from
c062df9 to
830ee2b
Compare
|
This looks pretty straightforward and again tests should pick up if there is an issue adding merge on pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor extraction for code readability
Before
Less readable
After
More readable - but that is a very relative concept!
Technical Details
This is a really blunt extraction of a chunk of code whose Raison D'Etre I don't quite know as yet.
I've done the absolute minimum variable cleanup to keep it really clean in the first instance
Comments
https://lab.civicrm.org/dev/core/issues/723