REF Don't pass activity object to addCaseActivityLinks

[mattwire]

Overview

Simplifies the transitional addCaseActivityLinks function by removing one of the passed parameters.

Before

Less refactorable

After

More refactorable

Technical Details

We switch addCaseActivityLinks to private as it should not be called from elsewhere (it was only added recently so this should not be an issue). Once the refactor is "complete" the function will disappear and be replace by actionLinks.

Comments

Partial from master...mattwire:case_links_refactor_part2

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I worked through this & it looks good to me - looks like this is a fn in toxic.json but the fishes weren't alerted @totten - I thought that dead fish protocol had survived but we just moved the toxic code to other fns