Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF Replace hardcoded IDs with pseudoconstants in activity form #14108

Merged

Conversation

mattwire
Copy link
Contributor

Overview

Replace hardcoded action, activity type and activity status IDs with constants/pseudoconstants

Before

More fragile code

After

Less fragile code

Technical Details

Standard replacements

Comments

@civibot
Copy link

civibot bot commented Apr 22, 2019

(Standard links)

@civibot civibot bot added the master label Apr 22, 2019
@mattwire mattwire force-pushed the form_activity_hardcoded_ids branch from 9f3c508 to 531d3b2 Compare April 22, 2019 14:21
@eileenmcnaughton
Copy link
Contributor

@colemanw's feedback addressed & I rechecked & it seemed all good

@eileenmcnaughton eileenmcnaughton merged commit 6eca48d into civicrm:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants