dev/core#889 - Refund throws a fatal error if the main contribution a…

[jitendrapurohit]

…mount is 0

Overview

Refund throws a fatal error if the main contribution amount is 0

Before

To replicate -

• Create an event with fee amount options = $0, $50, $100.
• Register contact A for an event with price $50.
• Change selection to $0. Main contribution amount updates to $0.
• Record refund of $50 -> Submit.
• Payment is refunded but the ajax form is stuck with an Error.

After

Refund form is submitted correctly.

Technical Details

As main contribution amount $contributionDAO->total_amount is 0, there is a division by zero error assignment to $paid var which throws an error when it is tried to insert as a row in financial item table.

Comments

Gitlab - https://lab.civicrm.org/dev/core/issues/889

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

In general I'm trying not to merge anything to do with handling payments until we finish the work on rationalising the payment create api function with the on-form function - currently stalled on this

#13689

However, if you want to add a unit test then even though this fix will likely be thrown away in the course of that work the bug-fix would be locked in by a test

(@monishdeb fyi)

[seamuslee001]

Jenkins re test this please

[seamuslee001]

I have added a unit test which replicates the issue for me locally in #14488

[eileenmcnaughton]

Merging since @seamuslee001 has added a test - fix seems sensible