Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate creating recipients from MailingJob.create. #14097

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Deprecate creating recipients from MailingJob.create. #14097

merged 1 commit into from
Jun 1, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 21, 2019 •
edited
Loading

Overview

deprecate code path towards code clean up

Before

not deprecated

After

deprecated

Technical Details

It is done in mailing create & then has to bypass MailingJob.create in order to not do it twice.

This ALSO bypasses hooks

Comments

@eileenmcnaughton
Deprecate creating recipients from MailingJob.create.
2dd8a2c 
It is done in mailing create & then has to bypass MailingJob.create in order to not do it twice.

This ALSO bypasses hooks
@civibot
Copy link

civibot bot commented Apr 21, 2019

(Standard links)

@civibot civibot bot added the master label Apr 21, 2019
@mattwire mattwire merged commit 15879bf into civicrm:master Jun 1, 2019
@eileenmcnaughton eileenmcnaughton deleted the mailin_test branch June 1, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @mattwire