dev/core/issues/743, Donot join relationship table when not required #14082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Thanks @pradpnayak ! I can confirm this fixes the issue for me. |
|
Merging based on @gareth-circle & the change appearing safe & sensible - although @pradpnayak I would note that moving from setting $relField to using $this-isTableSelected(..) when adding the join would be a code improvement here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/issues/743
Before
returned incorrect results
After
returned correct results
Technical Details
Used CRM_Utils_System::isNull() over isset() since all the fields in filters are always set and may be empty. isNull() functions handles isset and empty very well.