dev/core#562 Remove more DAO->free() calls #14071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been removing a few of these each release. They no longer provide any benefit as the resources are released in the deconstructor. OTOH they can in rare circumstances cause bugs. Previous removals have not caused any issues so the slow approach is starting to look overly cautious now
|
(Standard links)
|
|
Cleanup looks sensible, matches previous stuff done without issue, should be enough tests here adding merge on pass |
|
Merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code cleanup
Before
More obsolete code
After
Less obsolete code
Technical Details
We have been removing a few of these each release. They no longer provide any benefit
as the resources are released in the deconstructor. OTOH they can in rare circumstances cause bugs.
Previous removals have not caused any issues so the slow approach is starting to
look overly cautious now
Comments