Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove switch statement that no longer switches #13886

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Remove switch statement that no longer switches #13886

merged 1 commit into from
Mar 25, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code cleanup

Before

Less readable

After

More readable

Technical Details

Change is almost all whitespace

Comments

@jitendrapurohit Can you check this?

@civibot
Copy link

civibot bot commented Mar 25, 2019

(Standard links)

@civibot civibot bot added the master label Mar 25, 2019
jitendrapurohit
jitendrapurohit approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Tested on all search forms to confirm the changes. Works fine.

@eileenmcnaughton
Copy link
Contributor Author

Cool - I was going to leave this fix out of scope but then it was so glaringly obvious!

@eileenmcnaughton eileenmcnaughton merged commit f9a6d90 into civicrm:master Mar 25, 2019
@eileenmcnaughton eileenmcnaughton deleted the clean_fn branch March 25, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendrapurohit jitendrapurohit jitendrapurohit approved these changes

Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @jitendrapurohit