Remove mcrypt system status check #13770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Php 7.2 doesn't support this & it is being deprecated so having this here causes sites to try to install it - creating a migration problem they wouldn't otherwise have The situation here is unresolved but this check doesn't solve more confusion than it creates
|
(Standard links)
|
|
Test fails seem unrelated. I support removing this status check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove status check for mcrypt
Before
Status check error is mcrypt not present & smtp encryption in place
After
Error gone
Technical Details
Php 7.2 doesn't support this & it is being deprecated so having this here causes
sites to try to install it - creating a migration problem they wouldn't otherwise have
The situation here is unresolved but this check doesn't solve more confusion than it creates or help more than it hinders
Comments
Arose from this user-confusion discussion https://chat.civicrm.org/civicrm/pl/765mcnydrtfru8h8ixz9od3p3w