CRM/Contact - Fix fatal error on tag search #13743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a fatal error caused by the CommaSeparatedIntegers not accepting empty strings. This can be triggered by performing a search with "Tag(s) IS NULL" using the search builder.
|
(Standard links)
|
|
@jitendrapurohit ping |
|
Jenkins re test this please |
|
I'm going to merge this now tests are passing - I feel confident based on the related PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a regression in search builder when "Tag(s) IS NULL" is used.
Before
Searching for "Tag(s) IS NULL" triggers a fatal error because the CommaSeparatedIntegers does not accept empty strings.
After
Searching for "Tag(s) IS NULL" works because the validation is only performed if the value is not empty.
Comments
This is basically the same as #13738, only for tags.