Fix up e-notice error when using a user from email address same issue… #13737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@seamuslee001 style warning |
seamuslee001
force-pushed
the
pdf_receipts_fix_enotice
branch
from
5d97069
to
5b8e26b
Compare
|
unrelated fail - Feb 28 short-month issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as dev/core#644
Overview
This fixes an e-notice issue which is actually the same bug as shown in dev/core#644 but this time is exposed when re-sending a receipt.
Before
Using a user driven from email address generates e-notice when re-sending a receipt
After
no e-notice and from email address is correct
ping @MegaphoneJon @eileenmcnaughton