[minor cleanup] reduce params passed to searchQuery

[eileenmcnaughton]

Overview

Minor cleanup

Before

less readable

After

more readable

Technical Details

Where we are retrieving the sql we can call the inner function rather than passing 'true'
in other cases we are passing default values through

in general passing lots of variables to searchQuery in order to tweak the results is a bad code smell - ideally we could have some more specific functions to call - getCount, getAlphabetQuery and with the ones which do weird stuff we'd call an extracted function that gets an array - so we don't get a sql query & then str_replace out the select clause & parts we don't want

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@monishdeb are you able to merge this - trivial cleanup & the one line that is not in a test class has heavy test coverage

[monishdeb]

Patch reviewed and existing UTs passed too. Merging now