Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Extract record refund function #13691

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Function extraction

Before

Less readable

After

More readable

Technical Details

function extract & moved to Payment class

Comments

@monishdeb this should be pretty straight forward - just an extraction

@civibot
Copy link

civibot bot commented Feb 25, 2019

(Standard links)

@civibot civibot bot added the master label Feb 25, 2019
@monishdeb
Copy link
Member

Agree, this is a simple extraction and doesn't affect the refund workflow, also the code is moved to correct place Payment. recordRefundPayment. So I am going to merge it

@monishdeb monishdeb merged commit 83acc55 into civicrm:master Feb 25, 2019
@eileenmcnaughton eileenmcnaughton deleted the record_extract branch February 25, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants