Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CRM_Utils_SQL_TempTable to drop and create table. #13688

Merged
merged 1 commit into from
Feb 24, 2019

Conversation

mfb
Copy link
Contributor

@mfb mfb commented Feb 24, 2019

Overview

We could use the TempTable InterfaceI to create export table.

Before

SQL queries are used to drop and create table.

After

Use TempTable methods instead.

@civibot
Copy link

civibot bot commented Feb 24, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I'm OK merging this if jenkins passes it - this temp table has very heavy code coverage (even though IMHO it should not be created)

@eileenmcnaughton
Copy link
Contributor

I've added 'has-test' - this PR doesn't add a test so maybe it should be 'ok-without-test' but the test cover on that table is extensive

@mfb
Copy link
Contributor Author

mfb commented Feb 24, 2019

jenkins retest this please

@eileenmcnaughton eileenmcnaughton merged commit 7859a92 into civicrm:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants