reporting#10 - fix pagination on Contribution Detail report

[MegaphoneJon]

Overview

The Contribution Detail report doesn't show pagination when Full Group By is enabled.

Before

After

Technical Details

There were 2.5 bugs that needed to be fixed:

• The first temp table for this report sets a limit of 50 rows - so the second time through buildQuery(), the SQL statement SELECT * FROM civireport_contribution_detail_temp3 $this->_orderBy will never return more than 50, so the pager won't be set.
• setPager() assumes that a) the last SQL statement executed includes SQL_CALC_FOUND_ROWS; b) that $this->limit is set.

Finally, I found a call to setPager() in a place where it would never be correct (on a temp table that's not the "final" temp table) so I removed it.

Comments

I tried writing a test - but I couldn't determine how to write a method of CiviReportTestCase or CiviUnitTestCase that retrieved the template object. I know it's a protected property of the report object, which is retrievable by getReportObject(). If that method existed, I could write the test.

This is identical to #13665 but it's against the rc, per the request of @eileenmcnaughton.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

I just confirmed the bug as described and the fix - this should also be in our next 5.10 drop

[eileenmcnaughton]

Previous test fail was unrelated - merging https://test.civicrm.org/job/CiviCRM-Core-PR/24640/