Payment notification formatting, move greeting into table

[eileenmcnaughton]

Overview

Align greeting in payment notification email

Before

After

Technical Details

Comments

per #13655 (comment)

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[magnolia61]

I tested it, it does not show the greeting.
When I exhange the code:
{if $emailGreeting}<tr><td>{$emailGreeting},</td></tr>{/if}
to the line in most other templates is used it works ok (and in other templates it is not in its own tr/td
{assign var="greeting" value="{contact.email_greeting}"}{if $greeting}<p>{$greeting},</p>{/if}

[eileenmcnaughton]

@magnolia61 hmm - I guess we just merged support for $emailGreeting into master branch for that template & you might not have that locally yet?

[magnolia61]

You are right. I can confirm the template works fine on current master

[eileenmcnaughton]

@monishdeb are you good to merge this follow up per @magnolia61 request

[monishdeb]

Agree with the fix. Merging now.

Thanks, @magnolia61 for your review.