dev/core#739 Fix case detail report breaking when sorted by case type. #13666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
case_fix
branch
from
d4475e7 to
551defb
Compare
I removed the hacks to cope with poor metadata declaration & fixed the declaration - this should stop breaking now. Test added
eileenmcnaughton
force-pushed
the
case_fix
branch
from
551defb to
0f880d5
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
changed the title
|
This has been r-run on the ticket https://lab.civicrm.org/dev/core/issues/739#note_14126 - @seamuslee001 @colemanw are one of you happy to merge based on that testing? - look at the second commit only as there is a formatting one in there too |
|
Merging based on the testing on the ticket and the code looks sensible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix case detail report breaking when sorted by case type.
Before
Attempting to create a Case Detail report sorted by the field Case Type with the option "Section Header" checked does not work.
After
works
Technical Details
I removed the hacks to cope with poor metadata declaration & fixed the declaration - this should stop
breaking now. Test added
Comments
Array cleanup too
https://lab.civicrm.org/dev/core/issues/739