Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reporting#10 - fix pagination on Contribution Detail report #13665

Closed
wants to merge 1 commit into from
Closed

reporting#10 - fix pagination on Contribution Detail report #13665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CRM/Report/Form/Contribute/Detail.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,10 @@ public function statistics(&$rows) {
*
* @return string
*/
public function buildQuery($applyLimit = TRUE) {
public function buildQuery($applyLimit = FALSE) {
if ($this->isTempTableBuilt) {
return "SELECT * FROM civireport_contribution_detail_temp3 $this->_orderBy";
$this->limit();
return "SELECT SQL_CALC_FOUND_ROWS * FROM civireport_contribution_detail_temp3 $this->_orderBy $this->_limit";
}
return parent::buildQuery($applyLimit);
}
Expand Down Expand Up @@ -509,7 +510,6 @@ public function beginPostProcessCommon() {
// 1. use main contribution query to build temp table 1
$sql = $this->buildQuery();
$this->createTemporaryTable('civireport_contribution_detail_temp1', $sql);
$this->setPager();

// 2. customize main contribution query for soft credit, and build temp table 2 with soft credit contributions only
$this->queryMode = 'SoftCredit';
Expand Down